From a092ffaadb3a265a207acc558e6cd021fc3bb6d9 Mon Sep 17 00:00:00 2001 From: Husam Elbashir <39692071+HusamElbashir@users.noreply.github.com> Date: Tue, 10 Dec 2024 05:58:31 +0200 Subject: [PATCH] fix(node-ws): websocket upgrade header value case sensitivity (#876) --- .changeset/cool-coats-try.md | 5 +++++ packages/node-ws/src/index.ts | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/cool-coats-try.md diff --git a/.changeset/cool-coats-try.md b/.changeset/cool-coats-try.md new file mode 100644 index 00000000..fea70cbb --- /dev/null +++ b/.changeset/cool-coats-try.md @@ -0,0 +1,5 @@ +--- +'@hono/node-ws': patch +--- + +Fixed case-sensitivity of the WebSocket "Upgrade" header value diff --git a/packages/node-ws/src/index.ts b/packages/node-ws/src/index.ts index e8a45b8a..4ef69022 100644 --- a/packages/node-ws/src/index.ts +++ b/packages/node-ws/src/index.ts @@ -63,7 +63,7 @@ export const createNodeWebSocket = (init: NodeWebSocketInit): NodeWebSocket => { }, upgradeWebSocket: (createEvents) => async function upgradeWebSocket(c, next) { - if (c.req.header('upgrade') !== 'websocket') { + if (c.req.header('upgrade')?.toLowerCase() !== 'websocket') { // Not websocket await next() return