From 037fd94b7b0e17a049c979fa8750bd6673fdae19 Mon Sep 17 00:00:00 2001 From: Jonathan Haines Date: Fri, 11 Jul 2025 19:14:09 +1000 Subject: [PATCH] fix(session): types for SessionOptions cookie methods (#1301) --- .changeset/six-candles-repeat.md | 5 +++++ packages/session/deno.json | 18 ++++++++++++++++++ packages/session/src/index.ts | 6 +++--- 3 files changed, 26 insertions(+), 3 deletions(-) create mode 100644 .changeset/six-candles-repeat.md create mode 100644 packages/session/deno.json diff --git a/.changeset/six-candles-repeat.md b/.changeset/six-candles-repeat.md new file mode 100644 index 00000000..51fe307b --- /dev/null +++ b/.changeset/six-candles-repeat.md @@ -0,0 +1,5 @@ +--- +'@hono/session': patch +--- + +Fix types for `SessionOptions` cookie methods diff --git a/packages/session/deno.json b/packages/session/deno.json new file mode 100644 index 00000000..b7163eb9 --- /dev/null +++ b/packages/session/deno.json @@ -0,0 +1,18 @@ +{ + "name": "@hono/session", + "version": "0.1.0", + "license": "MIT", + "exports": { + ".": "./src/index.ts", + "./cookies": "./src/cookies.ts", + "./testing": "./src/helper/testing/index.ts" + }, + "imports": { + "hono": "jsr:@hono/hono@^4.8.3", + "jose": "jsr:@panva/jose@^6.0.11" + }, + "publish": { + "include": ["deno.json", "README.md", "src/**/*.ts"], + "exclude": ["src/**/*.test.ts"] + } +} diff --git a/packages/session/src/index.ts b/packages/session/src/index.ts index c959de48..017e3dc5 100644 --- a/packages/session/src/index.ts +++ b/packages/session/src/index.ts @@ -37,9 +37,9 @@ export interface SessionOptions extends SessionEvents { */ secret?: string | EncryptionKey - deleteCookie?: typeof cookie.deleteCookie - getCookie?: typeof cookie.getCookie - setCookie?: typeof cookie.setCookie + deleteCookie?: (c: Context, name: string, opt?: CookieOptions) => void + getCookie?: (c: Context, name: string) => string | undefined + setCookie?: (c: Context, name: string, value: string, opt?: CookieOptions) => void } export type SessionEnv = Env & {