helix/helix-term
Michael Davis 5532ef35d9
LSP: Remove future wrapper from `Client::notify`, `Client::reply`
Previously LSP notifications were sent within a future and most callers
used a `tokio::spawn` to send the notification, silently discarding any
failures like problems serializing parameters or sending on the channel.
It's possible that tokio could schedule futures out of intended order
though which could cause notifications where order is important, like
document synchronization, to become partially shuffled. This change
removes the future wrapper and logs all internal failures.

Also included in this commit is the same change for `Client::reply`
which was also unnecessarily wrapped in a future.

Co-authored-by: Pascal Kuthe <pascalkuthe@pm.me>
2025-02-01 19:32:37 -05:00
..
src LSP: Remove future wrapper from `Client::notify`, `Client::reply` 2025-02-01 19:32:37 -05:00
tests Do not record keys pressed by macros while recording a macro (#12733) 2025-01-30 18:14:04 -06:00
.gitignore Initial import. 2020-05-20 18:14:51 +09:00
Cargo.toml build(deps): bump the rust-dependencies group with 2 updates (#12707) 2025-01-27 17:19:26 -06:00
build.rs chore: clean up clippy lints (#11377) 2024-08-01 06:39:46 +09:00