Nikita Revenco
18aaf93da0
chore: remove Clone derive from Syntax
2025-03-25 14:41:27 +00:00
Nikita Revenco
4c5ceb5bed
test: add test for continuing comment in injection layers
2025-03-25 14:41:27 +00:00
Nikita Revenco
c72755437a
feat: continue comment uses injected comment tokens
2025-03-25 14:41:27 +00:00
Nikita Revenco
5b30bfe36e
fix: YAML formatting issues with injections
2025-03-25 14:41:27 +00:00
Nikita Revenco
4bb33459fa
feat: improve presentation of tree-sitter-injections
2025-03-25 14:41:27 +00:00
Nikita Revenco
37f8cbed3c
feat: upgrade `tree-sitter-injection` to show injections for entire file
2025-03-25 14:41:27 +00:00
Nikita Revenco
92469b431a
docs: add information on `tree-sitter-injection`
2025-03-25 14:41:27 +00:00
Nikita Revenco
56dedd10a7
fix: add `regex` to ignored layer configs
2025-03-25 14:41:27 +00:00
Nikita Revenco
d451077978
feat: add typable command to get injection layer for current range
2025-03-25 14:41:27 +00:00
Nikita Revenco
99d16170dc
fix: commenting full lines
2025-03-25 14:41:27 +00:00
Nikita Revenco
7d53290dd2
fix: panic
2025-03-25 14:41:27 +00:00
Nikita Revenco
e9683381b6
refactor: extract a separate toggle_comment_impl function
2025-03-25 14:41:27 +00:00
Nikita Revenco
093805b62c
perf: get rid of a `.clone()`
2025-03-25 14:41:27 +00:00
Nikita Revenco
63fb49c1b4
chore: clean up code
...
chore: remove comment
2025-03-25 14:41:27 +00:00
Nikita Revenco
6e451fe201
chore: remove useless file
2025-03-25 14:41:27 +00:00
Nikita Revenco
3714fc0cee
chore: remove unused imports
2025-03-25 14:41:27 +00:00
Nikita Revenco
c22eba38d5
chore: move all comment integration tests into a separate module
2025-03-25 14:41:27 +00:00
Nikita Revenco
ad3f9ececb
chore: remove unneeded files
2025-03-25 14:41:27 +00:00
Nikita Revenco
570911e589
fix: many single width selections panic
2025-03-25 14:41:27 +00:00
Nikita Revenco
ee0f22471e
chore: add brainstorm thoughts
2025-03-25 14:41:27 +00:00
Nikita Revenco
13b52e9d97
refactor: rename variables ,use iterator methods, separate vars for added and removed chars
2025-03-25 14:41:27 +00:00
Nikita Revenco
7a39fb8164
refactor: rename variable
2025-03-25 14:41:27 +00:00
Nikita Revenco
bbd7cb7bfb
fix: incorrect order of index additions
2025-03-25 14:41:27 +00:00
Nikita Revenco
76b3e6778d
chore: remove log statement
2025-03-25 14:41:27 +00:00
Nikita Revenco
31e2f739ee
fix: panic as no ranges were inserted
2025-03-25 14:41:27 +00:00
Nikita Revenco
5562e7ae8e
chore: add announcement file for PR
2025-03-25 14:41:27 +00:00
Nikita Revenco
b94d3a70e7
fix: multiple selections having incorrect range and not properly accounting for comment tokens
2025-03-25 14:41:27 +00:00
Nikita Revenco
621dec74be
test: write more tests for toggle comment, and add tests for toggle block comment
2025-03-25 14:41:27 +00:00
Nikita Revenco
7c24110061
feat: add integration tests for commenting through injection layers
2025-03-25 14:41:27 +00:00
Nikita Revenco
0a882107ed
fix: restore selections when created comment
2025-03-25 14:41:27 +00:00
Nikita Revenco
de7884c7dd
test: uncomment previosly skipped tests
2025-03-25 14:41:27 +00:00
Nikita Revenco
371dec3774
feat: block comment toggle and single line comment toggle
2025-03-25 14:41:27 +00:00
Nikita Revenco
544e460ac4
feat: implement toggle comment funcitonality for multiple comment tokens
2025-03-25 14:41:27 +00:00
Nikita Revenco
29e0a00eb0
feat: implement toggle comment for the simplest case
2025-03-25 14:41:27 +00:00
Nikita Revenco
d719f1572b
feat: gain access to injection-specific line and block comment tokens
2025-03-25 14:41:27 +00:00
Nikita Revenco
b10fc21169
chore: clean up code
2025-03-25 14:41:27 +00:00
Nikita Revenco
8fe3f90cbb
feat: use FnMut
2025-03-25 14:41:27 +00:00
Nikita Revenco
38bede20ef
feat: add new params
2025-03-25 14:41:27 +00:00
Nikita Revenco
70f27b390d
feat: add function to get LanguageConfiguration from a LayerId
...
Co-authored-by: the-mikedavis <mcarsondavis@gmail.com>
2025-03-25 14:41:27 +00:00
Michael Davis
388a3b78e3
Avoid removing modified documents in Editor::close_document
...
This fixes a regression from 6da1a79d80
. `:buffer-close` on an
unmodified document would cause later panics since the document should
not have been removed. Instead of eagerly removing the document on the
first line we need to wait until we've checked that it's unmodified.
2025-03-25 09:03:32 -04:00
Michael Davis
d43de14807
LSP: Avoid requesting document colors for ghost transactions
...
The point of ghost transactions is to avoid notifying language servers
about changes since the change is meant to be temporary. This is used
for completion while selecting items in the menu: updating the language
server would mess up incomplete completions.
When a document is changed by a ghost transaction the language server
will not be notified so its understanding of the document will not be
synchronized and any positions it sends may be out-of-date. So we should
avoid triggering a request for new document color information when a
document is changed by a ghost transaction.
2025-03-25 08:52:47 -04:00
dependabot[bot]
04d1180a0c
build(deps): bump the rust-dependencies group with 4 updates ( #13190 )
...
Bumps the rust-dependencies group with 4 updates: [tempfile](https://github.com/Stebalien/tempfile ), [log](https://github.com/rust-lang/log ), [rustix](https://github.com/bytecodealliance/rustix ) and [cc](https://github.com/rust-lang/cc-rs ).
Updates `tempfile` from 3.19.0 to 3.19.1
- [Changelog](https://github.com/Stebalien/tempfile/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Stebalien/tempfile/compare/v3.19.0...v3.19.1 )
Updates `log` from 0.4.26 to 0.4.27
- [Release notes](https://github.com/rust-lang/log/releases )
- [Changelog](https://github.com/rust-lang/log/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/log/compare/0.4.26...0.4.27 )
Updates `rustix` from 1.0.2 to 1.0.3
- [Release notes](https://github.com/bytecodealliance/rustix/releases )
- [Changelog](https://github.com/bytecodealliance/rustix/blob/main/CHANGES.md )
- [Commits](https://github.com/bytecodealliance/rustix/compare/v1.0.2...v1.0.3 )
Updates `cc` from 1.2.16 to 1.2.17
- [Release notes](https://github.com/rust-lang/cc-rs/releases )
- [Changelog](https://github.com/rust-lang/cc-rs/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/cc-rs/compare/cc-v1.2.16...cc-v1.2.17 )
---
updated-dependencies:
- dependency-name: tempfile
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: log
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: rustix
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: cc
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-03-25 07:40:40 -05:00
Nick
5adb4b7413
Allow `:theme` to show current theme ( #13192 )
...
Updates the signature for the command to take 0 arguments. This probably
regressed during 0efa8207d8
.
2025-03-25 18:43:26 +09:00
Sebastian Dörner
13b2dc31f5
Book: Add a section with links to "Helix mode" in non-Helix software. ( #12258 )
2025-03-24 08:21:37 -05:00
Nik Revenco
0ee5850016
Color swatches ( 🟩 green 🟥 #ffaaaa ) ( #12308 )
2025-03-23 16:07:02 -05:00
Asta Halkjær From
8ff544757f
Make `goto_word` highlights visible (same fix as #12904 ) ( #13174 )
2025-03-23 10:27:58 -05:00
Branch Vincent
f07c1c1b29
add `ui.text.directory` to onedark ( #13166 )
2025-03-23 09:33:23 -05:00
RoloEdits
8ad6e53b1f
build(grammar): remove `-fPIC` flag from windows build ( #13169 )
...
Even though there is a check for `is_like_msvc`, when setting `CXX` to
`clang++` this will miss that check and try to use `-fPIC`, which is an
invlaid flag for the target.
2025-03-23 09:32:56 -05:00
Ahmir Postell
6bedca8064
Add focus_nova theme ( #13144 )
2025-03-22 16:24:16 -05:00
Michael Davis
7e7a98560e
LSP: Eagerly decode request results in the client
...
Previously the `call` helper (and its related functions) returned a
`serde_json::Value` which was then decoded either later in the client
(see signature help and hover) or by the client's caller. This led to
some unnecessary boilerplate in the client:
let resp = self.call::<MyRequest>(params);
Some(async move { Ok(serde_json::from_value(resp.await?)?) })
and in the caller. It also allowed for mistakes with the types. The
workspace symbol request's calling code for example mistakenly decoded a
`lsp::WorkspaceSymbolResponse` as `Vec<lsp::SymbolInformation>` - one of
the untagged enum members (so it parsed successfully) but not the
correct type.
With this change, the `call` helper eagerly decodes the response to a
request as the `lsp::request::Request::Result` trait item. This is
similar to the old helper `request` (which has become redundant and has
been eliminated) but all work is done within the same async block which
avoids some awkward lifetimes. The return types of functions like
`Client::text_document_range_inlay_hints` are now more verbose but it is
no longer possible to accidentally decode as an incorrect type.
Additionally `Client::resolve_code_action` now uses the `call_with_ref`
helper to avoid an unnecessary clone.
2025-03-22 14:40:29 -04:00