3fdd98979c
fix: `goto_file_impl` incorrect use of `slice` instead of `byte_slice` ( #12673 )
2025-01-25 12:38:35 -06:00
81708b70e6
doc: Document `mdm` and `mrm` for popup help ( #12650 )
2025-01-24 11:46:19 -06:00
a63a2ad281
feat: specify custom lang server(s) for `:lsp-stop` and `:lsp-restart` ( #12578 )
...
Co-authored-by: Nikita Revenco <154856872+NikitaRevenco@users.noreply.github.com>
2025-01-23 18:14:35 -06:00
d4ade40983
Rename "file browser" => "file explorer"
...
Connects #11285
2025-01-23 18:17:56 -05:00
9d6ea773e9
prompt: Cap anchor to line length in cursor calculation
...
This prevents a panic when using `C-w` on a long single-word prompt line
for example.
Connects #12036
2025-01-23 17:33:28 -05:00
6b044aeb29
Add file browser ( #11285 )
2025-01-23 16:28:18 -06:00
8af33108f6
fix: better display of prompts on long inputs ( #12036 )
2025-01-23 15:56:34 -06:00
fa27ae16a7
Add path completion for multiple cursors ( #12550 )
2025-01-23 14:31:12 -06:00
650af50c13
fix: typos
2025-01-23 15:18:16 -05:00
c1d382a532
fix(lints): clippy 1.84
2025-01-23 15:18:16 -05:00
168b11e091
feat: passing multile of the same files in the arguments places a cursor at each position ( #12192 )
...
Co-authored-by: Nikita Revenco <154856872+NikitaRevenco@users.noreply.github.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
2025-01-23 14:04:02 -06:00
d123193902
Replace current file when loading in background from picker ( #12605 )
2025-01-23 12:49:20 -06:00
ccdb710431
minor: Rename '*' at eof integration test to be more specific
2025-01-21 09:08:36 -05:00
ba4793fca0
fix: panic when pressing `*` after the end of the file ( #12611 )
...
* fix: panic when pressing `*` at the end of the file
chore: remove incorrect additions
* docs: add info comment
* test: add new syntax to add a selection at the final character
* test: `*` panics when after the last char
* test: move into a more appopriate module
* test: fix failing
* test: account for Windows test suite
* test: choose a different strategy for custom syntax
* test: do not modify the syntax
* style: remove newline
---------
Co-authored-by: Nikita Revenco <154856872+NikitaRevenco@users.noreply.github.com>
2025-01-21 16:05:15 +09:00
076d8bd173
fix: surprising behaviour when changing line above a comment ( #12575 )
...
Co-authored-by: Nikita Revenco <154856872+NikitaRevenco@users.noreply.github.com>
2025-01-17 15:29:39 -06:00
69068770c8
Add extra logging for external formatters and formatting errors
...
This should help debug formatting failures when using external
formatters in the future. Previously we didn't log anything when an
external formatter failed despite having a custom error type for it.
2025-01-17 11:00:34 -05:00
4c41c5250c
Eliminate an unnecessary clone in insert_newline
2025-01-17 10:23:36 -05:00
d4ee22b483
Generate a .deb file ( #12453 )
2025-01-16 17:37:53 -06:00
3318953bf6
minor: Use more exact allocations in `insert_newline`
...
This is partially a style commit:
* Pull more bindings out the `change_by_selection` closure like the
line-ending string and the comment tokens used for continuation.
* Prefer `Editor::config` to `Document`'s config.
The rest is changes to places where `insert_newline` may allocate.
The first is to move `new_text` out of the `change_by_selection`
closure, reusing it between iterations. This is not necessarily always
an improvement as we need to clone the text for the return type of the
closure. `SmartString`'s `From<String>` implementation reuses the
allocation when the string is too long to inline and drops it if it is
short enough to inline though which can be wasteful. `From<&String>`
clones the string's allocation only when it is too long to be inlined,
so we save on allocations for any `new_text` short enough to be inlined.
The rest is changes to `new_text.reserve_exact`. Previously calls to
this function in this block mixed up character and byte indexing by
treating the length of the line-ending as 1. `reserve_exact` takes a
number of bytes to reserve and that may be 2 when `line_ending` is a
CRLF. A call to `reserve_exact` is also added to the branch used when
continuing line comments.
2025-01-15 10:57:03 -05:00
4bd17e542e
Fix offset tracking in `insert_newline`
...
#12177 changed `insert_newline`'s behavior to trim any trailing
whitespace on a line which came before a cursor. `insert_newline` would
previously never delete text. Even the whitespace stripping behavior in
#4854 worked by inserting text - a line ending at the beginning of the
line. `global_offs`, a variable that tracks the number of characters
inserted between iterations over the existing selection ranges, was not
updated to also account for text deleted by the trimming behavior,
causing cursors to be offset by the amount of trailing space deleted
and causing panics in some cases.
To fix this we need to subtract the number of trimmed whitespace
characters from `global_offs`. `global_offs` must become an `isize`
(was a `usize`) because it may become negative in cases where a lot of
trailing whitespace is trimmed. Integration tests have been added for
each of these cases.
Fixes #12461
Fixes #12495
Fixes #12539
2025-01-15 10:36:29 -05:00
60bff8feee
Fix `open_{below, above}` behaviour with multiple cursors ( #12465 )
2025-01-13 08:14:30 -06:00
e01775a667
fix: unable to detect Color completion item hex code for some LSPs ( #12501 )
...
Co-authored-by: Nikita Revenco <154856872+NikitaRevenco@users.noreply.github.com>
2025-01-12 09:40:19 -06:00
0f2ce303c5
Add directory name to `:cd` errors
...
For example `:cd README.md` would say "Not a directory" but would not
print the directory name. Now the error message includes some context
about the operation and requested directory.
2025-01-11 20:39:44 -05:00
931dd9c1dc
Fix a typo in join_selections ( #12452 )
...
Co-authored-by: Rose Hogenson <rosehogenson@posteo.net>
2025-01-08 08:42:41 -06:00
917174e546
Fix blank buffer picker preview on doc with no views
...
Reproduction:
* `hx`
* Open any file in a split (`<space>f` and choose anything with `<C-v>`)
* Close the split with `<C-w>q`
* Open up the buffer picker and look the file you opened previously
Previously the preview was empty in this case because the Document's
`selections` hashmap was empty and we returned early, giving `None`
instead of a FileLocation. Instead when the Document is not currently
open in any view we can show the document but with no range highlighted.
2025-01-07 15:11:15 -05:00
e698b20245
build(deps): bump the rust-dependencies group with 3 updates ( #12437 )
2025-01-06 19:34:21 -05:00
217818681e
Revert "refactor(shellwords)!: change arg handling strategy ( #11149 )"
...
This reverts commit 64b38d1a28
2025-01-06 12:39:53 -05:00
f80ae997f2
perf: cache `Document`s relative path ( #12385 )
2025-01-05 16:29:16 -06:00
64b38d1a28
refactor(shellwords)!: change arg handling strategy ( #11149 )
2025-01-05 12:18:30 -06:00
9cc056e755
fix (hx --health): Don't print headers in white ( #12355 )
2024-12-29 10:38:28 -06:00
073efe48f9
minor: Setup default keymap directly in xtask docgen
...
Instantiating EditorView is a lot of machinery which is unnecessary:
the default keymap is exposed through the `default` function in the
keymap module.
2024-12-28 21:42:09 -05:00
19c91dfb80
fix: string literals with format args not in `format!` ( #12354 )
2024-12-28 07:44:16 -06:00
c262fe41ab
Consistently replace line-endings in paste/replace commands
...
Previously we replaced line-endings in pasted text to the document
line-ending for some values in paste commands. We missed the `repeat`
values in paste though and didn't do any replacement in the replace
command.
Along with this change I've refactored the replace command to avoid
intermediary collections. We previously eagerly collected the values
from the input register as a `Vec<String>` but we can avoid both of
those conversions and only allocate for the conversion to a `Tendril`.
We can also switch from `str::repeat` to a manual implementation to
avoid the intermediary conversion to a String - this avoids an extra
allocation in the common case (i.e. no count).
Fixes #12329
2024-12-25 11:38:44 -05:00
a074129f9c
build(deps): bump the rust-dependencies group with 7 updates ( #12327 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
2024-12-25 10:05:50 -06:00
4f63a46e14
minor: Remove redundant condition in shell pipe trimming
...
`output.ends_with('\n')` implies `!output.is_empty()`
Connects #11183
2024-12-22 09:42:37 -05:00
ac4c017165
feat: autohelp for delete, replace and add surrounds ( #12262 )
2024-12-22 08:17:44 -06:00
ba6e6dc3dd
Colors for items in the completion menu ( #12299 )
2024-12-20 10:16:15 -06:00
355e381626
feat: use `ui.text.directory` for path completion item if its a folder ( #12295 )
2024-12-19 14:36:54 -06:00
9e4da4b950
Show parser availability in --health [LANG] ( #12228 )
2024-12-18 11:21:58 -06:00
91a5d407da
Allow theming directory prompt completions ( #12205 )
2024-12-17 21:13:42 -06:00
fcded6ce1e
Trim trailing colons from paths to allow copy/pasting git grep -n output ( #9963 )
...
Co-authored-by: Christian Schneider <schneider@search.ch>
2024-12-17 13:02:06 -06:00
1badd9e434
implement snippet tabstop support
2024-12-17 13:34:40 -05:00
66fb1e67c0
add fallback onNextKey
...
adds a variant of on_next_key callbacks that are only called when no other
mapping matches a key
2024-12-17 13:34:40 -05:00
609c29bf7e
add DocumentFocusLost event
2024-12-17 13:34:40 -05:00
5537e68b5e
add `changes` and `ghost_transaction` to DocumentDidChange events
2024-12-17 13:34:40 -05:00
312c64f0c2
build(deps): bump the rust-dependencies group with 10 updates ( #12277 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-16 18:48:13 -06:00
250d9fa8fe
Avoid allocating the `--help` message ( #12243 )
2024-12-16 11:16:48 -06:00
3b36cf1a15
Expand tildes in `:read` command ( #12271 )
2024-12-16 11:10:35 -06:00
e14c346ee7
Fix panic in `kill_to_end_of_line` when handling multibyte characters ( #12237 )
2024-12-13 14:04:52 -06:00
89a7cde2f0
Fix continuing comment token for first line ( #12215 )
2024-12-10 13:24:34 -06:00
5005c14e99
Add config option for continue commenting ( #12213 )
...
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
2024-12-09 17:31:41 -06:00
db1d84256f
fix: report correct amount of files opened and improved error message when Helix can't parse directory as file ( #12199 )
...
* feat: improve information on the amount of files loaded
* refactor: naming consitency Doc and not Buf
* fix: correct name of method
* chore: appease clippy
* feat: more human error information when Helix cannot start
* refatcor: use if guard on match arm
2024-12-08 20:14:29 +09:00
28953ef40f
Simplify `change_current_directory` and remove extra allocs
2024-12-05 18:50:31 -05:00
93deb1f6ae
feat: `:cd -` changes to the previous working directory ( #12194 )
...
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
2024-12-05 17:40:37 -06:00
fd3e889927
Add integration tests for line comment continuation
2024-12-05 20:53:53 +09:00
1e6fe00001
Trim all trailing whitespace on insert_newline
2024-12-05 20:53:53 +09:00
4c8175ca04
Draw each message line separately in `draw_eol_diagnostic`
...
`set_string_truncated` renders the entire string while ignoring
newlines, so if the diagnostic's message contains multiple lines it
produces messages like 'first linesecond line'.
To avoid these run-ons, this commit renders each line separately,
inserting double spaces for disambiguation.
2024-12-04 18:23:30 -06:00
715a13b2d3
Remove an incorrect comment
...
This was copied from the function above (set_style). I don't know enough
about the function to suggest an alternative.
2024-12-04 18:23:30 -06:00
565bfbba25
feat: `:cd` with no args changes to home directory ( #12042 )
2024-12-04 18:09:33 -06:00
7a2afdc080
Show an error when formatter is not available ( #12183 )
2024-12-04 08:27:54 -06:00
085c4fe4c8
docs: Eliminate improper use of "LSP" term
...
Sometimes we used "LSP" to mean "language server". This change
eliminates the improper "LSP" usage.
Ref https://github.com/helix-editor/helix/pull/12183#discussion_r1868436105
2024-12-03 18:29:44 -05:00
cf81e15315
build(deps): bump the rust-dependencies group with 3 updates ( #12181 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-02 18:27:49 -06:00
5ba97ba41e
fix(clippy): clippy 1.83 lints ( #12150 )
2024-12-02 08:23:32 -06:00
0f4729289b
fix: Remove leftover debug println! ( #12138 )
...
Introduced in dc941d6d24
2024-11-27 20:05:18 +09:00
7676106960
Search selection with word boundary detection ( #12126 )
...
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
2024-11-26 13:30:53 -06:00
80709cee61
build(deps): bump the rust-dependencies group with 4 updates ( #12129 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-25 18:06:54 -06:00
cbbeca6c52
fix(clippy): suppress `unused` lint on windows ( #12107 )
2024-11-22 08:10:11 -06:00
dc941d6d24
Add support for path completion ( #2608 )
...
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Co-authored-by: Pascal Kuthe <pascalkuthe@pm.me>
2024-11-21 21:12:36 -06:00
9e171e7d1d
Add default-yank-register option ( #11430 )
...
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
2024-11-20 17:24:55 -06:00
68ee87695b
Add clipboard provider configuration ( #10839 )
2024-11-20 16:06:23 -06:00
59b020ec91
Save an undo checkpoint before paste in insert mode ( #8121 )
2024-11-20 16:02:10 -06:00
f06f481ad9
build(deps): bump the rust-dependencies group with 5 updates ( #12088 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-20 15:56:56 -06:00
d489c03c4f
helix-term: Use workspace thiserror dep
2024-11-20 11:40:45 -06:00
f621423e7d
build(deps): bump thiserror from 1.0.64 to 2.0.3
...
Bumps [thiserror](https://github.com/dtolnay/thiserror ) from 1.0.64 to 2.0.3.
- [Release notes](https://github.com/dtolnay/thiserror/releases )
- [Commits](https://github.com/dtolnay/thiserror/compare/1.0.64...2.0.3 )
---
updated-dependencies:
- dependency-name: thiserror
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-11-20 11:40:45 -06:00
b5d56e57a6
build(deps): bump the rust-dependencies group across 1 directory with 11 updates
...
Bumps the rust-dependencies group with 10 updates in the / directory:
| Package | From | To |
| --- | --- | --- |
| [regex](https://github.com/rust-lang/regex ) | `1.11.0` | `1.11.1` |
| [url](https://github.com/servo/rust-url ) | `2.5.2` | `2.5.3` |
| [serde](https://github.com/serde-rs/serde ) | `1.0.210` | `1.0.215` |
| [encoding_rs](https://github.com/hsivonen/encoding_rs ) | `0.8.34` | `0.8.35` |
| [anyhow](https://github.com/dtolnay/anyhow ) | `1.0.90` | `1.0.93` |
| [tempfile](https://github.com/Stebalien/tempfile ) | `3.13.0` | `3.14.0` |
| [tokio](https://github.com/tokio-rs/tokio ) | `1.40.0` | `1.41.1` |
| [libc](https://github.com/rust-lang/libc ) | `0.2.161` | `0.2.162` |
| [cc](https://github.com/rust-lang/cc-rs ) | `1.1.31` | `1.1.37` |
| [gix](https://github.com/GitoxideLabs/gitoxide ) | `0.66.0` | `0.67.0` |
Updates `regex` from 1.11.0 to 1.11.1
- [Release notes](https://github.com/rust-lang/regex/releases )
- [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/regex/compare/1.11.0...1.11.1 )
Updates `url` from 2.5.2 to 2.5.3
- [Release notes](https://github.com/servo/rust-url/releases )
- [Commits](https://github.com/servo/rust-url/compare/v2.5.2...v2.5.3 )
Updates `serde` from 1.0.210 to 1.0.215
- [Release notes](https://github.com/serde-rs/serde/releases )
- [Commits](https://github.com/serde-rs/serde/compare/v1.0.210...v1.0.215 )
Updates `encoding_rs` from 0.8.34 to 0.8.35
- [Commits](https://github.com/hsivonen/encoding_rs/compare/v0.8.34...v0.8.35 )
Updates `anyhow` from 1.0.90 to 1.0.93
- [Release notes](https://github.com/dtolnay/anyhow/releases )
- [Commits](https://github.com/dtolnay/anyhow/compare/1.0.90...1.0.93 )
Updates `tempfile` from 3.13.0 to 3.14.0
- [Changelog](https://github.com/Stebalien/tempfile/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Stebalien/tempfile/compare/v3.13.0...v3.14.0 )
Updates `tokio` from 1.40.0 to 1.41.1
- [Release notes](https://github.com/tokio-rs/tokio/releases )
- [Commits](https://github.com/tokio-rs/tokio/compare/tokio-1.40.0...tokio-1.41.1 )
Updates `libc` from 0.2.161 to 0.2.162
- [Release notes](https://github.com/rust-lang/libc/releases )
- [Changelog](https://github.com/rust-lang/libc/blob/0.2.162/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/libc/compare/0.2.161...0.2.162 )
Updates `rustix` from 0.38.37 to 0.38.40
- [Release notes](https://github.com/bytecodealliance/rustix/releases )
- [Changelog](https://github.com/bytecodealliance/rustix/blob/main/CHANGELOG.md )
- [Commits](https://github.com/bytecodealliance/rustix/compare/v0.38.37...v0.38.40 )
Updates `cc` from 1.1.31 to 1.1.37
- [Release notes](https://github.com/rust-lang/cc-rs/releases )
- [Changelog](https://github.com/rust-lang/cc-rs/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/cc-rs/compare/cc-v1.1.31...cc-v1.1.37 )
Updates `gix` from 0.66.0 to 0.67.0
- [Release notes](https://github.com/GitoxideLabs/gitoxide/releases )
- [Changelog](https://github.com/GitoxideLabs/gitoxide/blob/main/CHANGELOG.md )
- [Commits](https://github.com/GitoxideLabs/gitoxide/compare/gix-v0.66.0...gix-v0.67.0 )
---
updated-dependencies:
- dependency-name: regex
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: url
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: serde
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: encoding_rs
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: anyhow
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: tempfile
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: rust-dependencies
- dependency-name: tokio
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: rust-dependencies
- dependency-name: libc
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: rustix
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: cc
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: gix
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: rust-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-11-13 15:30:17 +09:00
101a74bf6e
build(deps): bump the rust-dependencies group with 6 updates ( #11924 )
...
Bumps the rust-dependencies group with 6 updates:
| Package | From | To |
| --- | --- | --- |
| [serde_json](https://github.com/serde-rs/json ) | `1.0.128` | `1.0.132` |
| [anyhow](https://github.com/dtolnay/anyhow ) | `1.0.89` | `1.0.90` |
| [libc](https://github.com/rust-lang/libc ) | `0.2.159` | `0.2.161` |
| [fern](https://github.com/daboross/fern ) | `0.6.2` | `0.7.0` |
| [pulldown-cmark](https://github.com/raphlinus/pulldown-cmark ) | `0.12.1` | `0.12.2` |
| [cc](https://github.com/rust-lang/cc-rs ) | `1.1.30` | `1.1.31` |
Updates `serde_json` from 1.0.128 to 1.0.132
- [Release notes](https://github.com/serde-rs/json/releases )
- [Commits](https://github.com/serde-rs/json/compare/1.0.128...1.0.132 )
Updates `anyhow` from 1.0.89 to 1.0.90
- [Release notes](https://github.com/dtolnay/anyhow/releases )
- [Commits](https://github.com/dtolnay/anyhow/compare/1.0.89...1.0.90 )
Updates `libc` from 0.2.159 to 0.2.161
- [Release notes](https://github.com/rust-lang/libc/releases )
- [Changelog](https://github.com/rust-lang/libc/blob/0.2.161/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/libc/compare/0.2.159...0.2.161 )
Updates `fern` from 0.6.2 to 0.7.0
- [Release notes](https://github.com/daboross/fern/releases )
- [Changelog](https://github.com/daboross/fern/blob/main/CHANGELOG.md )
- [Commits](https://github.com/daboross/fern/compare/fern-0.6.2...fern-0.7.0 )
Updates `pulldown-cmark` from 0.12.1 to 0.12.2
- [Release notes](https://github.com/raphlinus/pulldown-cmark/releases )
- [Commits](https://github.com/raphlinus/pulldown-cmark/compare/v0.12.1...v0.12.2 )
Updates `cc` from 1.1.30 to 1.1.31
- [Release notes](https://github.com/rust-lang/cc-rs/releases )
- [Changelog](https://github.com/rust-lang/cc-rs/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/cc-rs/compare/cc-v1.1.30...cc-v1.1.31 )
---
updated-dependencies:
- dependency-name: serde_json
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: anyhow
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: libc
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: fern
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: rust-dependencies
- dependency-name: pulldown-cmark
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: cc
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-23 22:34:20 +09:00
be2884d800
Continue line comments ( #10996 )
2024-10-19 05:48:07 -04:00
f6d39cbc1d
refactor(lsp): handle out-of-range `active_signature` ( #11825 )
2024-10-06 08:54:17 -05:00
162028d444
Merge pull request #11486 from helix-editor/lsp-location-refactor
...
Replace uses of `lsp::Location` with a custom Location type
2024-10-04 03:33:35 +02:00
cb9307bb03
build(deps): bump the rust-dependencies group with 5 updates ( #11805 )
...
Bumps the rust-dependencies group with 5 updates:
| Package | From | To |
| --- | --- | --- |
| [once_cell](https://github.com/matklad/once_cell ) | `1.19.0` | `1.20.1` |
| [regex](https://github.com/rust-lang/regex ) | `1.10.6` | `1.11.0` |
| [tempfile](https://github.com/Stebalien/tempfile ) | `3.12.0` | `3.13.0` |
| [libc](https://github.com/rust-lang/libc ) | `0.2.158` | `0.2.159` |
| [cc](https://github.com/rust-lang/cc-rs ) | `1.1.21` | `1.1.23` |
Updates `once_cell` from 1.19.0 to 1.20.1
- [Changelog](https://github.com/matklad/once_cell/blob/master/CHANGELOG.md )
- [Commits](https://github.com/matklad/once_cell/compare/v1.19.0...v1.20.1 )
Updates `regex` from 1.10.6 to 1.11.0
- [Release notes](https://github.com/rust-lang/regex/releases )
- [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/regex/compare/1.10.6...1.11.0 )
Updates `tempfile` from 3.12.0 to 3.13.0
- [Changelog](https://github.com/Stebalien/tempfile/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Stebalien/tempfile/compare/v3.12.0...v3.13.0 )
Updates `libc` from 0.2.158 to 0.2.159
- [Release notes](https://github.com/rust-lang/libc/releases )
- [Changelog](https://github.com/rust-lang/libc/blob/0.2.159/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/libc/compare/0.2.158...0.2.159 )
Updates `cc` from 1.1.21 to 1.1.23
- [Release notes](https://github.com/rust-lang/cc-rs/releases )
- [Changelog](https://github.com/rust-lang/cc-rs/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/cc-rs/compare/cc-v1.1.21...cc-v1.1.23 )
---
updated-dependencies:
- dependency-name: once_cell
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: rust-dependencies
- dependency-name: regex
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: rust-dependencies
- dependency-name: tempfile
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: rust-dependencies
- dependency-name: libc
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: cc
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-01 10:05:07 +09:00
8cdce9212c
Improve tree-sitter-subtree ( #11663 )
...
* Make unnamed nodes visible in subtree view
* Refine command description
* Update generated docs
* Update unit test expected output
2024-09-30 10:59:31 +09:00
73deabaa40
Fix panic when drawing at the edge of the screen. ( #11737 )
...
When pressing tab at the edge of the screen, Helix panics in debug mode
subtracting position.col - self.offset.col.
To correctly account for graphemes that are partially visible,
column_in_bounds takes a width and returns whether the whole range is
in bounds.
Co-authored-by: Rose Hogenson <rosehogenson@posteo.net>
2024-09-23 02:17:02 +09:00
8b1764d164
Join single-line comments with J. ( #11742 )
...
Fixes #8565 .
Co-authored-by: Rose Hogenson <rosehogenson@posteo.net>
2024-09-23 02:16:24 +09:00
b85e824ba9
Handle window/showMessage and display it bellow status line ( #5535 )
...
* Handle window/showMessage and display it bellow status line
* Enable `editor.lsp.display_messages` by default
---------
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
2024-09-18 21:43:06 +02:00
237cbe4bca
build(deps): bump the rust-dependencies group with 4 updates ( #11669 )
...
Bumps the rust-dependencies group with 4 updates: [globset](https://github.com/BurntSushi/ripgrep ), [ignore](https://github.com/BurntSushi/ripgrep ), [grep-regex](https://github.com/BurntSushi/ripgrep ) and [grep-searcher](https://github.com/BurntSushi/ripgrep ).
Updates `globset` from 0.4.14 to 0.4.15
- [Release notes](https://github.com/BurntSushi/ripgrep/releases )
- [Changelog](https://github.com/BurntSushi/ripgrep/blob/master/CHANGELOG.md )
- [Commits](https://github.com/BurntSushi/ripgrep/compare/globset-0.4.14...ignore-0.4.15 )
Updates `ignore` from 0.4.22 to 0.4.23
- [Release notes](https://github.com/BurntSushi/ripgrep/releases )
- [Changelog](https://github.com/BurntSushi/ripgrep/blob/master/CHANGELOG.md )
- [Commits](https://github.com/BurntSushi/ripgrep/commits )
Updates `grep-regex` from 0.1.12 to 0.1.13
- [Release notes](https://github.com/BurntSushi/ripgrep/releases )
- [Changelog](https://github.com/BurntSushi/ripgrep/blob/master/CHANGELOG.md )
- [Commits](https://github.com/BurntSushi/ripgrep/compare/grep-regex-0.1.12...0.1.13 )
Updates `grep-searcher` from 0.1.13 to 0.1.14
- [Release notes](https://github.com/BurntSushi/ripgrep/releases )
- [Changelog](https://github.com/BurntSushi/ripgrep/blob/master/CHANGELOG.md )
- [Commits](https://github.com/BurntSushi/ripgrep/compare/grep-searcher-0.1.13...0.1.14 )
---
updated-dependencies:
- dependency-name: globset
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: ignore
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: grep-regex
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: grep-searcher
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-10 22:59:03 +09:00
48e9357788
picker: Removed owned variant of PathOrId
...
The only caller of `from_path_buf` was removed in the parent commit
allowing us to drop owned variant of path's `Cow`. With this change we
never need to allocate in the picker preview callback.
2024-09-03 09:48:32 -04:00
606b957172
Replace uses of lsp::Location with a custom Location type
...
The lsp location type has the lsp's URI type and a range. We can replace
that with a custom type private to the lsp commands module that uses the
core URI type instead.
We can't entirely replace the type with a new Location type in core.
That type might look like:
pub struct Location {
uri: crate::Uri,
range: crate::Range,
}
But we can't convert every `lsp::Location` to this type because for
definitions, references and diagnostics language servers send documents
which we haven't opened yet, so we don't have the information to convert
an `lsp::Range` (line+col) to a `helix_core::Range` (char indexing).
This cleans up the picker definitions in this file so that they can all
use helpers like `jump_to_location` and `location_to_file_location` for
the picker preview. It also removes the only use of the deprecated
`PathOrId::from_path_buf` function, allowing us to drop the owned
variant of that type in the child commit.
2024-09-03 09:48:32 -04:00
38e6fcd5c5
build(deps): bump the rust-dependencies group with 7 updates ( #11530 )
...
Bumps the rust-dependencies group with 7 updates:
| Package | From | To |
| --- | --- | --- |
| [serde](https://github.com/serde-rs/serde ) | `1.0.207` | `1.0.208` |
| [serde_json](https://github.com/serde-rs/json ) | `1.0.124` | `1.0.125` |
| [tokio](https://github.com/tokio-rs/tokio ) | `1.39.2` | `1.39.3` |
| [libc](https://github.com/rust-lang/libc ) | `0.2.155` | `0.2.158` |
| [pulldown-cmark](https://github.com/raphlinus/pulldown-cmark ) | `0.11.0` | `0.12.0` |
| [cc](https://github.com/rust-lang/cc-rs ) | `1.1.10` | `1.1.13` |
| [which](https://github.com/harryfei/which-rs ) | `6.0.2` | `6.0.3` |
Updates `serde` from 1.0.207 to 1.0.208
- [Release notes](https://github.com/serde-rs/serde/releases )
- [Commits](https://github.com/serde-rs/serde/compare/v1.0.207...v1.0.208 )
Updates `serde_json` from 1.0.124 to 1.0.125
- [Release notes](https://github.com/serde-rs/json/releases )
- [Commits](https://github.com/serde-rs/json/compare/v1.0.124...1.0.125 )
Updates `tokio` from 1.39.2 to 1.39.3
- [Release notes](https://github.com/tokio-rs/tokio/releases )
- [Commits](https://github.com/tokio-rs/tokio/compare/tokio-1.39.2...tokio-1.39.3 )
Updates `libc` from 0.2.155 to 0.2.158
- [Release notes](https://github.com/rust-lang/libc/releases )
- [Changelog](https://github.com/rust-lang/libc/blob/0.2.158/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/libc/compare/0.2.155...0.2.158 )
Updates `pulldown-cmark` from 0.11.0 to 0.12.0
- [Release notes](https://github.com/raphlinus/pulldown-cmark/releases )
- [Commits](https://github.com/raphlinus/pulldown-cmark/compare/v0.11.0...v0.12.0 )
Updates `cc` from 1.1.10 to 1.1.13
- [Release notes](https://github.com/rust-lang/cc-rs/releases )
- [Changelog](https://github.com/rust-lang/cc-rs/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/cc-rs/compare/cc-v1.1.10...cc-v1.1.13 )
Updates `which` from 6.0.2 to 6.0.3
- [Release notes](https://github.com/harryfei/which-rs/releases )
- [Changelog](https://github.com/harryfei/which-rs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/harryfei/which-rs/compare/6.0.2...6.0.3 )
---
updated-dependencies:
- dependency-name: serde
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: serde_json
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: tokio
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: libc
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: pulldown-cmark
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: rust-dependencies
- dependency-name: cc
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: which
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-21 09:41:49 +09:00
4e729dea02
fix: ensure view is initiated for jump_* commands ( #11529 )
2024-08-20 00:28:59 +02:00
112b2878ae
build(deps): bump the rust-dependencies group with 4 updates ( #11476 )
...
Bumps the rust-dependencies group with 4 updates: [serde](https://github.com/serde-rs/serde ), [serde_json](https://github.com/serde-rs/json ), [tempfile](https://github.com/Stebalien/tempfile ) and [cc](https://github.com/rust-lang/cc-rs ).
Updates `serde` from 1.0.204 to 1.0.207
- [Release notes](https://github.com/serde-rs/serde/releases )
- [Commits](https://github.com/serde-rs/serde/compare/v1.0.204...v1.0.207 )
Updates `serde_json` from 1.0.122 to 1.0.124
- [Release notes](https://github.com/serde-rs/json/releases )
- [Commits](https://github.com/serde-rs/json/compare/v1.0.122...v1.0.124 )
Updates `tempfile` from 3.11.0 to 3.12.0
- [Changelog](https://github.com/Stebalien/tempfile/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Stebalien/tempfile/commits )
Updates `cc` from 1.1.7 to 1.1.10
- [Release notes](https://github.com/rust-lang/cc-rs/releases )
- [Changelog](https://github.com/rust-lang/cc-rs/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/cc-rs/compare/cc-v1.1.7...cc-v1.1.10 )
---
updated-dependencies:
- dependency-name: serde
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: serde_json
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: tempfile
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: rust-dependencies
- dependency-name: cc
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-13 07:59:42 +02:00
e46cedfc26
refactor(commands): `trim_end` of `sh` output ( #11161 )
2024-08-11 10:24:51 -05:00
b7820ee668
Disallow macro keybindings within command sequences
...
This is a temporary limitation because of the way that command sequences
are executed. Each command is currently executed back-to-back
synchronously, but macros are by design queued up for the compositor.
So macros mixed into a command sequence will behave undesirably: they
will be executed after the rest of the static and/or typable commands
in the sequence.
This is pending a larger refactor of how we handle commands.
<https://redirect.github.com/helix-editor/helix/issues/5555 > has
further details and <https://redirect.github.com/helix-editor/helix/issues/4508 >
discusses a similar problem faced by the command palette.
2024-08-10 00:39:47 +09:00
1098a348aa
Parse and execute macro mappable commands
2024-08-10 00:39:47 +09:00
f52251960a
fix(picker): no longer `trim` search pattern ( #11406 )
2024-08-10 00:26:09 +09:00
518425e055
Add commands for movement by subwords ( #8147 )
...
* Allow moving by subword
* Add tests for subword movement
2024-08-08 13:57:59 -05:00
6ba46e5cbf
Fix crossterm compilation on macOS
2024-08-07 06:46:59 +09:00
92a87dbc31
build(deps): bump the rust-dependencies group with 9 updates
...
Bumps the rust-dependencies group with 9 updates:
| Package | From | To |
| --- | --- | --- |
| [regex](https://github.com/rust-lang/regex ) | `1.10.5` | `1.10.6` |
| [dunce](https://gitlab.com/kornelski/dunce ) | `1.0.4` | `1.0.5` |
| [serde_json](https://github.com/serde-rs/json ) | `1.0.121` | `1.0.122` |
| [toml](https://github.com/toml-rs/toml ) | `0.8.16` | `0.8.19` |
| [crossterm](https://github.com/crossterm-rs/crossterm ) | `0.27.0` | `0.28.1` |
| [tempfile](https://github.com/Stebalien/tempfile ) | `3.10.1` | `3.11.0` |
| [serde_repr](https://github.com/dtolnay/serde-repr ) | `0.1.12` | `0.1.19` |
| [which](https://github.com/harryfei/which-rs ) | `6.0.1` | `6.0.2` |
| [windows-sys](https://github.com/microsoft/windows-rs ) | `0.52.0` | `0.59.0` |
Updates `regex` from 1.10.5 to 1.10.6
- [Release notes](https://github.com/rust-lang/regex/releases )
- [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/regex/compare/1.10.5...1.10.6 )
Updates `dunce` from 1.0.4 to 1.0.5
- [Commits](https://gitlab.com/kornelski/dunce/compare/v1.0.4...v1.0.5 )
Updates `serde_json` from 1.0.121 to 1.0.122
- [Release notes](https://github.com/serde-rs/json/releases )
- [Commits](https://github.com/serde-rs/json/compare/v1.0.121...v1.0.122 )
Updates `toml` from 0.8.16 to 0.8.19
- [Commits](https://github.com/toml-rs/toml/compare/toml-v0.8.16...toml-v0.8.19 )
Updates `crossterm` from 0.27.0 to 0.28.1
- [Release notes](https://github.com/crossterm-rs/crossterm/releases )
- [Changelog](https://github.com/crossterm-rs/crossterm/blob/master/CHANGELOG.md )
- [Commits](https://github.com/crossterm-rs/crossterm/commits )
Updates `tempfile` from 3.10.1 to 3.11.0
- [Changelog](https://github.com/Stebalien/tempfile/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Stebalien/tempfile/compare/v3.10.1...v3.11.0 )
Updates `serde_repr` from 0.1.12 to 0.1.19
- [Release notes](https://github.com/dtolnay/serde-repr/releases )
- [Commits](https://github.com/dtolnay/serde-repr/compare/0.1.12...0.1.19 )
Updates `which` from 6.0.1 to 6.0.2
- [Release notes](https://github.com/harryfei/which-rs/releases )
- [Changelog](https://github.com/harryfei/which-rs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/harryfei/which-rs/compare/6.0.1...6.0.2 )
Updates `windows-sys` from 0.52.0 to 0.59.0
- [Release notes](https://github.com/microsoft/windows-rs/releases )
- [Commits](https://github.com/microsoft/windows-rs/compare/0.52.0...0.59.0 )
---
updated-dependencies:
- dependency-name: regex
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: dunce
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: serde_json
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: toml
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: crossterm
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: rust-dependencies
- dependency-name: tempfile
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: rust-dependencies
- dependency-name: serde_repr
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: which
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: windows-sys
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: rust-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-08-07 04:27:05 +09:00
0a4432b104
Add statusline errors when nothing is selected with `s`, `K`, `A-K` ( #11370 )
2024-08-02 21:04:19 +09:00
cfe80acb6f
output `stderr` in `:sh` popup if shell commands fail ( #11239 )
...
* refactor(commands): output `stderr` in `:sh` popup
* refactor(commands): switch to `from_utf8_lossy`
This way something is always displayed.
* refactor: no longer log stderr output on failure
2024-08-01 01:29:14 +02:00
86aecc96a1
chore: clean up clippy lints ( #11377 )
...
Using clippy 1.80.0. Also cleans up some that were windows only.
2024-08-01 06:39:46 +09:00
magackame
Darshan Kumawat
Nikita Revenco
Michael Davis
Denys Rybalka
Yomain
TornaxO7
Rolo
Jose Alvarez
janos-r
rhogenson
dependabot[bot]
Jean Abou Samra
Nikita Revenco
Eduardo Rittner Coelho
Christian Schneider
Pascal Kuthe
Integral
Aaalibaba
Takumi Matsuura
Ian Hobson
Tomasz Zurkowski
Poliorcetics
Milan Vaško
Philipp Mildenberger
yehor
Alfie Richards
chtenb
Ayoub Benali
Jefta
Blaž Hrastnik
André Carneiro