helix

Commit Graph

Author	SHA1	Message	Date
Blaž Hrastnik	425de09d21	Fix tests again	2022-06-27 17:35:23 +09:00
Blaž Hrastnik	24f03097e3	Remove some more unwraps	2022-06-27 17:27:44 +09:00
Michael Davis	45ce1ebdb6	embed jsonrpc types from jsonrpc-core crate (#2801 ) We should not depend on jsonrpc-core anymore: * The project just announced it's no longer actively maintained[^1], preferring their new implementation in `jsonrpsee`. * The types are too strict: we would benefit from removing some `#[serde(deny_unknown_fields)]` annotations to allow language servers that disrespect the spec[^2]. * We don't use much of the project. Just the types out of core. These are easy to embed directly into the `helix-lsp` crate. [^1]: https://github.com/paritytech/jsonrpc/pull/674 [^2]: https://github.com/helix-editor/helix/issues/2786	2022-06-18 12:59:57 +09:00

Author

SHA1

Message

Date

Blaž Hrastnik

425de09d21

Fix tests again

2022-06-27 17:35:23 +09:00

Blaž Hrastnik

24f03097e3

Remove some more unwraps

2022-06-27 17:27:44 +09:00

Michael Davis

45ce1ebdb6

embed jsonrpc types from jsonrpc-core crate (#2801 )

We should not depend on jsonrpc-core anymore:

* The project just announced it's no longer actively maintained[^1],
  preferring their new implementation in `jsonrpsee`.
* The types are too strict: we would benefit from removing some
  `#[serde(deny_unknown_fields)]` annotations to allow language
  servers that disrespect the spec[^2].
* We don't use much of the project. Just the types out of core.
  These are easy to embed directly into the `helix-lsp` crate.

[^1]: https://github.com/paritytech/jsonrpc/pull/674
[^2]: https://github.com/helix-editor/helix/issues/2786

2022-06-18 12:59:57 +09:00

3 Commits (1caba2d3e8e16752d7d659b58c51931451a1cb47)