suimeng
/
helix
mirror of https://github.com/helix-editor/helix
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: Don't crash on empty completion, don't retrigger on close

pull/821/head
Blaž Hrastnik 2021-10-07 10:37:35 +09:00
parent 8ca91891d1
commit f692ede2b7
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
helix-term/src/ui/editor.rs
View File

@ -730,6 +730,12 @@ impl EditorView {
) { ) {
let mut completion = let mut completion =
Completion::new(editor, items, offset_encoding, start_offset, trigger_offset); Completion::new(editor, items, offset_encoding, start_offset, trigger_offset);
if completion.is_empty() {
// skip if we got no completion results
return;
}
// TODO : propagate required size on resize to completion too // TODO : propagate required size on resize to completion too
completion.required_size((size.width, size.height)); completion.required_size((size.width, size.height));
self.completion = Some(completion); self.completion = Some(completion);
@ -939,6 +945,7 @@ impl Component for EditorView {
if callback.is_some() { if callback.is_some() {
// assume close_fn // assume close_fn
self.completion = None; self.completion = None;
cxt.editor.clear_idle_timer(); // don't retrigger
} }
} }
} }
@ -952,6 +959,7 @@ impl Component for EditorView {
completion.update(&mut cxt); completion.update(&mut cxt);
if completion.is_empty() { if completion.is_empty() {
self.completion = None; self.completion = None;
cxt.editor.clear_idle_timer(); // don't retrigger
} }
} }
} }