From e8aa25e3324f41f644bf62bbd4503e75dd7a459f Mon Sep 17 00:00:00 2001 From: Dustin Lagoy Date: Thu, 3 Apr 2025 09:35:30 -0700 Subject: [PATCH] add error reporting to coverage reading --- helix-view/src/coverage.rs | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/helix-view/src/coverage.rs b/helix-view/src/coverage.rs index df25e4898..43d87c755 100644 --- a/helix-view/src/coverage.rs +++ b/helix-view/src/coverage.rs @@ -123,11 +123,22 @@ fn find_coverage_file() -> Option { } fn read_cobertura_coverage(path: &std::path::PathBuf) -> Option { - let file = File::open(path).ok()?; - let metadata = file.metadata().ok()?; + let file = File::open(path) + .inspect_err(|e| log::info!("error opening {:?}: {:?}", path, e)) + .ok()?; + let metadata = file + .metadata() + .inspect_err(|e| log::info!("error reading metadata for {:?}: {:?}", path, e)) + .ok()?; + let modified = metadata + .modified() + .inspect_err(|e| log::info!("error reading timestamp for {:?}: {:?}", path, e)) + .ok()?; let reader = BufReader::new(file); - let mut tmp: RawCoverage = from_reader(reader).ok()?; - tmp.modified_time = metadata.modified().ok(); + let mut tmp: RawCoverage = from_reader(reader) + .inspect_err(|e| log::info!("error parsing coverage for {:?}: {:?}", path, e)) + .ok()?; + tmp.modified_time = Some(modified); Some(tmp.into()) }