From b09847a6236f3eb04d5f903327c9d4e21c5cea67 Mon Sep 17 00:00:00 2001 From: Michael Davis Date: Wed, 16 Jul 2025 09:38:31 -0400 Subject: [PATCH] Enable inline diagnostics by default --- book/src/editor.md | 10 ---------- helix-view/src/annotations/diagnostics.rs | 2 +- helix-view/src/editor.rs | 2 +- 3 files changed, 2 insertions(+), 12 deletions(-) diff --git a/book/src/editor.md b/book/src/editor.md index b264201f5..61b1f6a7d 100644 --- a/book/src/editor.md +++ b/book/src/editor.md @@ -467,13 +467,3 @@ fn main() { └─ no such value in this scope } ``` - - -The new diagnostic rendering is not yet enabled by default. As soon as end of line or inline diagnostics are enabled the old diagnostics rendering is automatically disabled. The recommended default setting are: - -```toml -[editor] -end-of-line-diagnostics = "hint" -[editor.inline-diagnostics] -cursor-line = "warning" # show warnings and errors on the cursorline inline -``` diff --git a/helix-view/src/annotations/diagnostics.rs b/helix-view/src/annotations/diagnostics.rs index 7802ca637..be36cd010 100644 --- a/helix-view/src/annotations/diagnostics.rs +++ b/helix-view/src/annotations/diagnostics.rs @@ -109,7 +109,7 @@ impl InlineDiagnosticsConfig { impl Default for InlineDiagnosticsConfig { fn default() -> Self { InlineDiagnosticsConfig { - cursor_line: DiagnosticFilter::Disable, + cursor_line: DiagnosticFilter::Enable(Severity::Warning), other_lines: DiagnosticFilter::Disable, min_diagnostic_width: 40, prefix_len: 1, diff --git a/helix-view/src/editor.rs b/helix-view/src/editor.rs index 27dc45235..fc34d2949 100644 --- a/helix-view/src/editor.rs +++ b/helix-view/src/editor.rs @@ -1032,7 +1032,7 @@ impl Default for Config { indent_heuristic: IndentationHeuristic::default(), jump_label_alphabet: ('a'..='z').collect(), inline_diagnostics: InlineDiagnosticsConfig::default(), - end_of_line_diagnostics: DiagnosticFilter::Disable, + end_of_line_diagnostics: DiagnosticFilter::Enable(Severity::Hint), clipboard_provider: ClipboardProvider::default(), editor_config: true, }