suimeng
/
helix
mirror of https://github.com/helix-editor/helix
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Rename reset to default (#8114) 

Use `default` instead of `reset`, as this is the conventional name for ANSI codes 39/49. The word `reset` should be reserved for ANSI code `0`, which resets both fg and bg colors at once, while also removing all modifiers. While the code uses the value name `Reset`, this is misleading and should not leak into the user space.
pull/8118/head
chtenb 2023-08-30 09:38:29 +02:00 committed by GitHub
parent 0cb595e226
commit 7fffc0a5d1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
book/src/themes.md
View File

@ -70,7 +70,7 @@ over it and is merged into the default palette.
| Color Name | | Color Name |
| --- | | --- |
| `reset` | | `default` |
| `black` | | `black` |
| `red` | | `red` |
| `green` | | `green` |

2
helix-view/src/theme.rs
View File

@ -359,7 +359,7 @@ impl Default for ThemePalette {
fn default() -> Self { fn default() -> Self {
Self { Self {
palette: hashmap! { palette: hashmap! {
"reset".to_string() => Color::Reset, "default".to_string() => Color::Reset,
"black".to_string() => Color::Black, "black".to_string() => Color::Black,
"red".to_string() => Color::Red, "red".to_string() => Color::Red,
"green".to_string() => Color::Green, "green".to_string() => Color::Green,