suimeng
/
helix
mirror of https://github.com/helix-editor/helix
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

dap: Avoid cloning *entire* stack frames when picking a thread

pull/574/head
Blaž Hrastnik 2021-11-07 18:56:09 +09:00
parent 5803de2067
commit 757babb1b4
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
helix-term/src/commands/dap.rs
View File

@ -115,7 +115,6 @@ fn thread_picker(cx: &mut Context, callback_fn: impl Fn(&mut Editor, &dap::Threa
} }
let thread_states = debugger.thread_states.clone(); let thread_states = debugger.thread_states.clone();
let frames = debugger.stack_frames.clone();
let picker = FilePicker::new( let picker = FilePicker::new(
threads, threads,
move |thread| { move |thread| {
@ -129,8 +128,14 @@ fn thread_picker(cx: &mut Context, callback_fn: impl Fn(&mut Editor, &dap::Threa
.into() .into()
}, },
move |cx, thread, _action| callback_fn(cx.editor, thread), move |cx, thread, _action| callback_fn(cx.editor, thread),
move |_editor, thread| { move |editor, thread| {
if let Some(frame) = frames.get(&thread.id).and_then(|bt| bt.get(0)) { let frame = editor
.debugger
.as_ref()
.and_then(|debugger| debugger.stack_frames.get(&thread.id))
.and_then(|bt| bt.get(0));
if let Some(frame) = frame {
frame frame
.source .source
.as_ref() .as_ref()