suimeng
/
helix
mirror of https://github.com/helix-editor/helix
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

completion: Don't panic on timeout/no result, just do nothing.

pull/8/head
Blaž Hrastnik 2021-01-06 13:44:29 +09:00
parent 3cbab20908
commit 6ec0f8e80f
1 changed files with 27 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
helix-term/src/commands.rs
View File

@ -851,8 +851,10 @@ pub fn completion(cx: &mut Context) {
.timeout(Duration::from_secs(2)), .timeout(Duration::from_secs(2)),
) )
.expect("completion failed!") .expect("completion failed!")
.expect("completion failed!"); .unwrap_or_default(); // if timeout, just return
// TODO: if no completion, show some message or something
if !res.is_empty() {
let picker = ui::Picker::new( let picker = ui::Picker::new(
res, res,
|item| { |item| {
@ -876,6 +878,8 @@ pub fn completion(cx: &mut Context) {
}, },
)); ));
// TODO: when iterating over items, show the docs in popup // TODO!: when iterating over items, show the docs in popup
// language server client needs to be accessible via a registry of some sort // language server client needs to be accessible via a registry of some sort
}
} }