diff --git a/helix-term/src/commands.rs b/helix-term/src/commands.rs index 0cc366665..6e7188b2f 100644 --- a/helix-term/src/commands.rs +++ b/helix-term/src/commands.rs @@ -2047,8 +2047,6 @@ fn copy_selection_on_visual_line(cx: &mut Context, direction: Direction) { // currently uses the deprecated `visual_coords_at_pos`/`pos_at_visual_coords` functions // as this function ignores softwrapping (and virtual text) and instead only cares // about "text visual position" -// -// TODO: implement a variant of that uses visual lines and respects virtual text fn copy_selection_on_line(cx: &mut Context, direction: Direction) { use helix_core::{pos_at_visual_coords, visual_coords_at_pos}; diff --git a/helix-term/src/commands/lsp.rs b/helix-term/src/commands/lsp.rs index 801e2a9b9..a6d4b424d 100644 --- a/helix-term/src/commands/lsp.rs +++ b/helix-term/src/commands/lsp.rs @@ -252,6 +252,9 @@ fn diag_picker( .into() }, ), + ui::PickerColumn::new("source", |item: &PickerDiagnostic, _| { + item.diag.source.as_deref().unwrap_or("").into() + }), ui::PickerColumn::new("code", |item: &PickerDiagnostic, _| { match item.diag.code.as_ref() { Some(NumberOrString::Number(n)) => n.to_string().into(), @@ -263,12 +266,12 @@ fn diag_picker( item.diag.message.as_str().into() }), ]; - let mut primary_column = 2; // message + let mut primary_column = 3; // message if format == DiagnosticsFormat::ShowSourcePath { columns.insert( // between message code and message - 2, + 3, ui::PickerColumn::new("path", |item: &PickerDiagnostic, _| { if let Some(path) = item.location.uri.as_path() { path::get_truncated_path(path)