suimeng
/
helix
mirror of https://github.com/helix-editor/helix
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

refactor: cast to u16 in a single place

pull/13197/head
Nik Revenco 2025-04-14 17:01:01 +01:00
parent 7c7bd20159
commit 13df887cca
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
helix-term/src/ui/editor.rs
View File

@ -104,7 +104,7 @@ impl EditorView {
Align::Center => longest_center = longest_center.max(width), Align::Center => longest_center = longest_center.max(width),
} }
)* )*
(lines, longest_left, longest_center) (lines, longest_left as u16, longest_center as u16)
}}; }};
} }
@ -152,25 +152,25 @@ impl EditorView {
}; };
// how many total lines there are in the welcome screen // how many total lines there are in the welcome screen
let lines_count = lines.len(); let lines_count = lines.len() as u16;
// the y-coordinate where we start drawing the welcome screen // the y-coordinate where we start drawing the welcome screen
let y_start = view.area.y + (view.area.height / 2).saturating_sub(lines_count as u16 / 2); let y_start = view.area.y + (view.area.height / 2).saturating_sub(lines_count / 2);
// y-coordinate of the center of the viewport // y-coordinate of the center of the viewport
let y_center = view.area.x + view.area.width / 2; let y_center = view.area.x + view.area.width / 2;
// the x-coordinate where we start drawing the welcome screen // the x-coordinate where we start drawing the welcome screen
// +2 to make the text look like its in the center instead of on the side // +2 to make the text look like its in the center instead of on the side
let x_start_left = let x_start_left =
view.area.x + (view.area.width / 2).saturating_sub(len_of_longest_left as u16 / 2) + 2; view.area.x + (view.area.width / 2).saturating_sub(len_of_longest_left / 2) + 2;
let has_x_left_overflow = (x_start_left + len_of_longest_left as u16) > view.area.width; let has_x_left_overflow = (x_start_left + len_of_longest_left) > view.area.width;
let has_x_center_overflow = len_of_longest_center as u16 > view.area.width; let has_x_center_overflow = len_of_longest_center > view.area.width;
let has_x_overflow = has_x_left_overflow || has_x_center_overflow; let has_x_overflow = has_x_left_overflow || has_x_center_overflow;
// we want lines_count < view.area.height so it does not get drawn // we want lines_count < view.area.height so it does not get drawn
// over the status line // over the status line
let has_y_overflow = lines_count as u16 >= view.area.height; let has_y_overflow = lines_count >= view.area.height;
if has_x_overflow || has_y_overflow { if has_x_overflow || has_y_overflow {
return; return;