suimeng
/
helix
mirror of https://github.com/helix-editor/helix
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use DoubleEndedIterator instead of collect to Vec for reversing 

Co-authored-by: Pascal Kuthe <pascal.kuthe@semimod.de>
pull/2507/head
Philipp Mildenberger 2023-03-18 17:00:57 +01:00
parent dd2f74794a
commit 0637691eb1
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
helix-term/src/commands.rs
View File

@ -3076,8 +3076,6 @@ fn goto_prev_diag(cx: &mut Context) {
let diag = doc let diag = doc
.shown_diagnostics() .shown_diagnostics()
.collect::<Vec<_>>()
.into_iter()
.rev() .rev()
.find(|diag| diag.range.start < cursor_pos) .find(|diag| diag.range.start < cursor_pos)
.or_else(|| doc.shown_diagnostics().last()); .or_else(|| doc.shown_diagnostics().last());

2
helix-view/src/document.rs
View File

@ -1607,7 +1607,7 @@ impl Document {
&self.diagnostics &self.diagnostics
} }
pub fn shown_diagnostics(&self) -> impl Iterator<Item = &Diagnostic> { pub fn shown_diagnostics(&self) -> impl Iterator<Item = &Diagnostic> + DoubleEndedIterator {
let ls_ids: HashSet<_> = self let ls_ids: HashSet<_> = self
.language_servers_with_feature(LanguageServerFeature::Diagnostics) .language_servers_with_feature(LanguageServerFeature::Diagnostics)
.iter() .iter()